snleee commented on a change in pull request #7368:
URL: https://github.com/apache/pinot/pull/7368#discussion_r719060967
##########
File path:
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/MergeRollupTaskGenerator.java
##########
@@ -277,6 +288,7 @@ public String getTaskType() {
}
Long prevWatermarkMs =
mergeRollupTaskMetadata.getWatermarkMap().put(mergeLevel, windowStartMs);
+ setWatermarkMs(offlineTableName, mergeLevel, waterMarkMs, bufferMs,
bucketMs);
Review comment:
I got confused due to the following line from the log. I updated the log
as well to correctly log old & new watermark. The code did not correctly log
the info like the following:
```
Update watermark of mergeLevel: 1day for table: xxx from: 1632700800000 to:
1632700800000
Update watermark of mergeLevel: 1day for table: xxx from: 1632700800000 to:
1632700800000
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
