snleee commented on a change in pull request #7368:
URL: https://github.com/apache/pinot/pull/7368#discussion_r719080772
##########
File path:
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/MergeRollupTaskGenerator.java
##########
@@ -339,6 +351,21 @@ public String getTaskType() {
.info("Finished generating task configs for table: {} for task: {},
numTasks: {}", offlineTableName, taskType,
pinotTaskConfigsForTable.size());
}
+
+ // Reset watermarks for invalid tables. This covers the metrics clean up
when the table is removed or the merge
+ // config is added and then removed.
+ LeadControllerManager leadControllerManager =
_clusterInfoAccessor.getLeaderControllerManager();
+ List<String> cleanUpCandidates = new ArrayList<>();
+ for (String tableNameWithType : _mergeRollupWatermarks.keySet()) {
+ if (!candidateMergeTables.contains(tableNameWithType) ||
!leadControllerManager
Review comment:
Added the `TODO` comment in `cleanUpMetrics()`. I will address this from
the separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
