richardstartin opened a new pull request #7610: URL: https://github.com/apache/pinot/pull/7610
## Description I was surprised to find #7599 didn't apply everywhere because there are actually two sets of `String` utilities: `StringUtils` and `StringUtil`. This is a mostly automated refactor: * Modernise implementations of `StringUtil.encodeUtf8` and `StringUtil.decodeUtf8`, then inline and remove them * Inline `StringUtils.encodeUtf8` and `StringUtils.decodeUtf8`, then remove them and delete the class * Inline `StringUtil.join` which is a trivial delegation to Apache Commons `StringUtils.join`, remove the method * Repurpose `StringUtil` as `StringSanitizer` as it now only provides a sanitisation of strings. Beyond the sanitisation which was left in place, it's hard to think of a string utility not provided succinctly by either the JDK itself, Guava or Apache Commons, all with which are available. ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion) * [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete the section below on Release Notes) Does this PR fix a zero-downtime upgrade introduced earlier? * [ ] Yes (Please label this as **<code>backward-incompat</code>**, and complete the section below on Release Notes) Does this PR otherwise need attention when creating release notes? Things to consider: - New configuration options - Deprecation of configurations - Signature changes to public methods/interfaces - New plugins added or old plugins removed * [ ] Yes (Please label this PR as **<code>release-notes</code>** and complete the section on Release Notes) ## Release Notes <!-- If you have tagged this as either backward-incompat or release-notes, you MUST add text here that you would like to see appear in release notes of the next release. --> <!-- If you have a series of commits adding or enabling a feature, then add this section only in final commit that marks the feature completed. Refer to earlier release notes to see examples of text. --> ## Documentation <!-- If you have introduced a new feature or configuration, please add it to the documentation as well. See https://docs.pinot.apache.org/developers/developers-and-contributors/update-document --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
