mcvsubbu commented on a change in pull request #7610:
URL: https://github.com/apache/pinot/pull/7610#discussion_r733831615
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/StringUtil.java
##########
@@ -28,7 +27,6 @@ private StringUtil() {
}
Review comment:
I agree, there is no reason to put this in spi. Interfaces in spi are
supposed to be backward compatible, and evolve in a compatible fashion. There
is no such need with this (purely internal to pinot) class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
