richardstartin opened a new pull request #7622:
URL: https://github.com/apache/pinot/pull/7622
## Description
Speed up `ByteArray.hashCode` which speeds up building column statistics.
Unfortunately the algorithm needs to be maintained in case it has been used for
partitioning, but it can be sped up easily by breaking a data dependency in the
loop.
```java
@State(Scope.Benchmark)
public class BenchmarkByteArray {
@Param({"7", "127", "1023"})
int _size;
ByteArray _bytes;
@Setup(Level.Trial)
public void init() {
byte[] bytes = new byte[_size];
ThreadLocalRandom.current().nextBytes(bytes);
_bytes = new ByteArray(bytes);
}
@Benchmark
public int byteArrayHashCode() {
return _bytes.hashCode();
}
@Benchmark
public int arraysHashCode() {
return Arrays.hashCode(_bytes.getBytes());
}
}
```
```
Benchmark (_size) Mode Cnt Score Error
Units
BenchmarkByteArray.arraysHashCode 7 avgt 5 6.823 ± 3.155
ns/op
BenchmarkByteArray.arraysHashCode 127 avgt 5 83.459 ± 5.859
ns/op
BenchmarkByteArray.arraysHashCode 1023 avgt 5 678.600 ± 4.842
ns/op
BenchmarkByteArray.byteArrayHashCode 7 avgt 5 6.294 ± 0.021
ns/op
BenchmarkByteArray.byteArrayHashCode 127 avgt 5 56.796 ± 1.975
ns/op
BenchmarkByteArray.byteArrayHashCode 1023 avgt 5 406.462 ± 3.246
ns/op
```
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order:
Controller, Broker, Server, Minion)
* [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete
the section below on Release Notes)
Does this PR fix a zero-downtime upgrade introduced earlier?
* [ ] Yes (Please label this as **<code>backward-incompat</code>**, and
complete the section below on Release Notes)
Does this PR otherwise need attention when creating release notes? Things to
consider:
- New configuration options
- Deprecation of configurations
- Signature changes to public methods/interfaces
- New plugins added or old plugins removed
* [ ] Yes (Please label this PR as **<code>release-notes</code>** and
complete the section on Release Notes)
## Release Notes
<!-- If you have tagged this as either backward-incompat or release-notes,
you MUST add text here that you would like to see appear in release notes of
the
next release. -->
<!-- If you have a series of commits adding or enabling a feature, then
add this section only in final commit that marks the feature completed.
Refer to earlier release notes to see examples of text.
-->
## Documentation
<!-- If you have introduced a new feature or configuration, please add it to
the documentation as well.
See
https://docs.pinot.apache.org/developers/developers-and-contributors/update-document
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
