richardstartin commented on a change in pull request #7622:
URL: https://github.com/apache/pinot/pull/7622#discussion_r734886249
##########
File path: pinot-spi/src/main/java/org/apache/pinot/spi/utils/ByteArray.java
##########
@@ -94,7 +94,23 @@ public boolean equals(Object o) {
@Override
public int hashCode() {
- return Arrays.hashCode(_bytes);
+ int hash = 1;
+ int i = 0;
+ for (; i + 7 < _bytes.length; i += 8) {
+ hash = -1807454463 * hash
+ + 1742810335 * _bytes[i]
+ + 887503681 * _bytes[i + 1]
+ + 28629151 * _bytes[i + 2]
+ + 923521 * _bytes[i + 3]
+ + 29791 * _bytes[i + 4]
+ + 961 * _bytes[i + 5]
+ + 31 * _bytes[i + 6]
+ + _bytes[i + 7];
+ }
+ for (; i < _bytes.length; i++) {
+ hash = 31 * hash + _bytes[i];
+ }
+ return hash;
Review comment:
That's not what the test does. It tests for a large number of randomly
sized arrays, but needs to guarantee that the case where the main loop is
skipped over and it goes straight into the post loop (length < 8).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
