mqliang commented on a change in pull request #7624:
URL: https://github.com/apache/pinot/pull/7624#discussion_r734924360
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/recommender/rules/impl/BloomFilterRule.java
##########
@@ -109,7 +109,8 @@ private FixedLenBitset parsePredicateList(FilterContext
filterContext) {
String colName = lhs.toString();
if (lhs.getType() == ExpressionContext.Type.FUNCTION) {
LOGGER.trace("Skipping the function {}", colName);
- } else if (filterContext.getPredicate().getType() == Predicate.Type.EQ) {
+ } else if (filterContext.getPredicate().getType() == Predicate.Type.EQ
+ || filterContext.getPredicate().getType() == Predicate.Type.IN) {
Review comment:
As we not leverage BloomFilter to prune a segment when item count of IN
clause is larger than
`pinot.server.query.executor.pruner.columnvaluesegmentpruner.inpredicate.threshold`
(default value 10):
https://github.com/apache/pinot/blob/7e9ca6a5a4afe0d4e283ac1307c45430e474cbf2/pinot-core/src/main/java/org/apache/pinot/core/query/pruner/ColumnValueSegmentPruner.java#L258
Add BloomFilter for IN predicate when item count > 10 is useless. Add a
condition here to consider IN clause item count also?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
