GSharayu commented on a change in pull request #7624:
URL: https://github.com/apache/pinot/pull/7624#discussion_r735931999
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/recommender/rules/impl/BloomFilterRule.java
##########
@@ -109,7 +109,8 @@ private FixedLenBitset parsePredicateList(FilterContext
filterContext) {
String colName = lhs.toString();
if (lhs.getType() == ExpressionContext.Type.FUNCTION) {
LOGGER.trace("Skipping the function {}", colName);
- } else if (filterContext.getPredicate().getType() == Predicate.Type.EQ) {
+ } else if (filterContext.getPredicate().getType() == Predicate.Type.EQ
+ || filterContext.getPredicate().getType() == Predicate.Type.IN) {
Review comment:
I think the value of 10 is configurable. Also the rule engine should not
assume any thresholds while recommending index
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
