walterddr commented on pull request #7631: URL: https://github.com/apache/pinot/pull/7631#issuecomment-951332041
> Just noticed that constructor retain the original field and just adds the new field as nullable. In that case, this should be fine. @siddharthteotia: yes. jackson has this limitation that only one `@JsonCreator` annotated constructor can be used. i dunno if there's any better way. > @walterddr could you add a test config with multiple indexes to `testConfigs/` so `TableConfigTest` checks it can be deserialised (which is what is proving your change is backwards compatible with old configs, incidentally)? I already added a multiple indexes FieldConfigs in TestSerde. did you mean I should also add a fieldConfigList item in the backward-compatibility test cases, e.g. in `compatibility-verifier/sample-test-suite/config/feature-test-1.json`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
