Jackie-Jiang commented on a change in pull request #7631:
URL: https://github.com/apache/pinot/pull/7631#discussion_r736883777
##########
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/FieldConfig.java
##########
@@ -86,8 +107,14 @@ public EncodingType getEncodingType() {
}
@Nullable
+ @Deprecated
public IndexType getIndexType() {
- return _indexType;
+ return _indexTypes.size() > 0 ? _indexTypes.get(0) : null;
+ }
+
+ @Nullable
Review comment:
Remove the annotation
##########
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/FieldConfig.java
##########
@@ -44,20 +46,39 @@
private final String _name;
private final EncodingType _encodingType;
- private final IndexType _indexType;
+ private final List<IndexType> _indexTypes;
private final CompressionCodec _compressionCodec;
private final Map<String, String> _properties;
+ @Deprecated
+ public FieldConfig(String name,
Review comment:
(optional, code format) keep parameters in the same line. Same for the
other constructor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
