xiangfu0 commented on a change in pull request #7880:
URL: https://github.com/apache/pinot/pull/7880#discussion_r766084000
##########
File path:
pinot-tools/src/main/java/org/apache/pinot/tools/service/PinotServiceManager.java
##########
@@ -211,17 +206,20 @@ public boolean stopPinotInstance(ServiceStartable
instance) {
}
public void start() {
- LOGGER.info("Registering service status handler");
- ServiceStatus.setServiceStatusCallback(_instanceId, new
PinotServiceManagerStatusCallback(this));
-
- if (_port < 0) {
+ if (_port <= 0) {
LOGGER.info("Skip Starting Pinot Service Manager admin application");
} else {
+ LOGGER.info("Registering service status handler");
+ ServiceStatus.setServiceStatusCallback(_instanceId, new
PinotServiceManagerStatusCallback(this));
Review comment:
Users can start a PinotSM without bootstrap services, then later on
start/stop services on it.
We need one healthCheck here to tell that this PinotServiceMananger is up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
