jadami10 commented on a change in pull request #7880:
URL: https://github.com/apache/pinot/pull/7880#discussion_r766187323
##########
File path:
pinot-tools/src/main/java/org/apache/pinot/tools/service/PinotServiceManagerStatusCallback.java
##########
@@ -30,19 +30,23 @@ public
PinotServiceManagerStatusCallback(PinotServiceManager pinotServiceManager
@Override
public ServiceStatus.Status getServiceStatus() {
+ if (_pinotServiceManager.isShuttingDown()) {
Review comment:
ok nifty. you can't set `_isShuttingDown` back to true, and we always
check this first, so if `stopAll` ever gets called, then we're guaranteed to
stop returning `GOOD`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
