jadami10 commented on a change in pull request #7880:
URL: https://github.com/apache/pinot/pull/7880#discussion_r766726453
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotBrokerHealthCheck.java
##########
@@ -50,7 +55,7 @@
@ApiResponse(code = 503, message = "Broker is not healthy")
})
public String getBrokerHealth() {
- ServiceStatus.Status status = ServiceStatus.getServiceStatus();
+ ServiceStatus.Status status = ServiceStatus.getServiceStatus(_instanceId);
Review comment:
So doing this will healthcheck just the broker, but I think the broker
will still return 200s while it's draining connections.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
