KKcorps commented on a change in pull request #7965:
URL: https://github.com/apache/pinot/pull/7965#discussion_r776464405
##########
File path:
pinot-plugins/pinot-stream-ingestion/pinot-kinesis/src/main/java/org/apache/pinot/plugin/stream/kinesis/KinesisStreamMetadataProvider.java
##########
@@ -108,8 +108,6 @@ public StreamPartitionMsgOffset
fetchStreamPartitionOffset(OffsetCriteria offset
if (shard == null) { // Shard has expired
shardsEnded.add(shardId);
continue;
- // FIXME: Here we assume that we were done consuming the shard before
it expired.
- // Handle edge case where consumer lags behind, resulting in shard to
expire before it is all consumed
Review comment:
Ok. What would you prefer, A LOG to just mark an expiring shard or a LOG
to warn users that although we are expiring a shard the data is not consumed
completely from it and hence might be some data loss?
Makes sense to LOG the second action but it will reflect poorly on the
database since there is no inbuilt solution to this problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
