KKcorps commented on a change in pull request #7965:
URL: https://github.com/apache/pinot/pull/7965#discussion_r776587817
##########
File path:
pinot-plugins/pinot-stream-ingestion/pinot-kinesis/src/main/java/org/apache/pinot/plugin/stream/kinesis/KinesisStreamMetadataProvider.java
##########
@@ -108,8 +108,6 @@ public StreamPartitionMsgOffset
fetchStreamPartitionOffset(OffsetCriteria offset
if (shard == null) { // Shard has expired
shardsEnded.add(shardId);
continue;
- // FIXME: Here we assume that we were done consuming the shard before
it expired.
- // Handle edge case where consumer lags behind, resulting in shard to
expire before it is all consumed
Review comment:
Added the log. Implementing an exact check if data loss has occurred or
not won't be possible in this class since there is no information about what is
the last sequence id (i.e. offset) in the expired shard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
