Jackie-Jiang commented on a change in pull request #7906:
URL: https://github.com/apache/pinot/pull/7906#discussion_r787042881
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartialUpsertHandler.java
##########
@@ -48,13 +49,29 @@
private final String _tableNameWithType;
private boolean _allSegmentsLoaded;
- public PartialUpsertHandler(HelixManager helixManager, String
tableNameWithType,
- Map<String, UpsertConfig.Strategy> partialUpsertStrategies) {
+ public PartialUpsertHandler(HelixManager helixManager, String
tableNameWithType, Schema schema,
+ Map<String, UpsertConfig.Strategy> partialUpsertStrategies,
UpsertConfig.Strategy defaultPartialUpsertStrategy,
+ String comparisonColumn) {
Review comment:
Annotate it as nullable
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartialUpsertHandler.java
##########
@@ -48,13 +49,29 @@
private final String _tableNameWithType;
private boolean _allSegmentsLoaded;
- public PartialUpsertHandler(HelixManager helixManager, String
tableNameWithType,
- Map<String, UpsertConfig.Strategy> partialUpsertStrategies) {
+ public PartialUpsertHandler(HelixManager helixManager, String
tableNameWithType, Schema schema,
+ Map<String, UpsertConfig.Strategy> partialUpsertStrategies,
UpsertConfig.Strategy defaultPartialUpsertStrategy,
+ String comparisonColumn) {
_helixManager = helixManager;
_tableNameWithType = tableNameWithType;
for (Map.Entry<String, UpsertConfig.Strategy> entry :
partialUpsertStrategies.entrySet()) {
_column2Mergers.put(entry.getKey(),
PartialUpsertMergerFactory.getMerger(entry.getValue()));
}
+ // For all physical columns (including date time columns) except for
primary key columns and comparison column.
+ // If no comparison column is configured, use main time column as the
comparison time.
+ for (String columnName : schema.getColumnNames()) {
+ if (!schema.getPrimaryKeyColumns().contains(columnName) &&
!_column2Mergers.containsKey(columnName)) {
+ if (comparisonColumn != null) {
+ if (!comparisonColumn.equals(columnName)) {
+ _column2Mergers.put(columnName,
PartialUpsertMergerFactory.getMerger(defaultPartialUpsertStrategy));
+ }
+ } else {
+ if (!schema.getDateTimeNames().contains(columnName)) {
Review comment:
The main time column is configured within the table config
`validationConfig`
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartialUpsertHandler.java
##########
@@ -48,13 +49,29 @@
private final String _tableNameWithType;
private boolean _allSegmentsLoaded;
- public PartialUpsertHandler(HelixManager helixManager, String
tableNameWithType,
- Map<String, UpsertConfig.Strategy> partialUpsertStrategies) {
+ public PartialUpsertHandler(HelixManager helixManager, String
tableNameWithType, Schema schema,
+ Map<String, UpsertConfig.Strategy> partialUpsertStrategies,
UpsertConfig.Strategy defaultPartialUpsertStrategy,
+ String comparisonColumn) {
_helixManager = helixManager;
_tableNameWithType = tableNameWithType;
for (Map.Entry<String, UpsertConfig.Strategy> entry :
partialUpsertStrategies.entrySet()) {
_column2Mergers.put(entry.getKey(),
PartialUpsertMergerFactory.getMerger(entry.getValue()));
}
+ // For all physical columns (including date time columns) except for
primary key columns and comparison column.
+ // If no comparison column is configured, use main time column as the
comparison time.
+ for (String columnName : schema.getColumnNames()) {
Review comment:
```suggestion
for (String columnName : schema.getPhysicalColumnNames()) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
