Jackie-Jiang commented on a change in pull request #7906:
URL: https://github.com/apache/pinot/pull/7906#discussion_r787994529
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java
##########
@@ -164,8 +164,9 @@ protected void doInit() {
PartialUpsertHandler partialUpsertHandler = null;
if (isPartialUpsertEnabled()) {
- partialUpsertHandler =
- new PartialUpsertHandler(_helixManager, _tableNameWithType,
upsertConfig.getPartialUpsertStrategies());
+ partialUpsertHandler = new PartialUpsertHandler(_helixManager,
_tableNameWithType, schema,
+ upsertConfig.getPartialUpsertStrategies(),
upsertConfig.getDefaultPartialUpsertStrategy(),
+ tableConfig.getValidationConfig().getTimeColumnName(),
upsertConfig.getComparisonColumn());
Review comment:
This can be simplified to avoid extra handling in the method
(comparisonColumn is non-null this way)
```suggestion
String comparisonColumn = upsertConfig.getComparisonColumn();
if (comparisonColumn == null) {
comparisonColumn =
tableConfig.getValidationConfig().getTimeColumnName();
}
partialUpsertHandler = new PartialUpsertHandler(_helixManager,
_tableNameWithType, schema,
upsertConfig.getPartialUpsertStrategies(),
upsertConfig.getDefaultPartialUpsertStrategy(), comparisonColumn);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
