kishoreg commented on pull request #8074: URL: https://github.com/apache/pinot/pull/8074#issuecomment-1022898022
@snleee what is your take on the behavior I suggested? - default behavior remains the same by having threshold = -1. - Operators can explicitly set a threshold to change default behavior - Users can still override the threshold on a per query basis either using query option or new argument to distinctCount function. I also wanted to call out again that asking users to use distinctcounthll is not a feasible solution because distinctcounthll will always use hyperloglog and return approximate results. What this PR is trying to add is a way to automatically switch to hyperloglog if the distinct set exceeds a threshold and this is dependent on the data and query. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
