snleee edited a comment on pull request #8074: URL: https://github.com/apache/pinot/pull/8074#issuecomment-1023543563
@kishoreg Oh, so we want the new behavior where we return the correct result until the threshold and return the approximate after threshold. In that case, using `distinctcounthll` will not work and I would +1 on Jackie's approach. That will achieve both. (1. keep the default behavior 2. add the ability to override the default behavior for advanced admin) @Jackie-Jiang How will you deal with the new input `hllLog2m=8;hllConversionThreshold=10` when we fall back to the new function with config? The original distinctcount function currently doesn't get the second parameter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
