xiangfu0 commented on a change in pull request #7997:
URL: https://github.com/apache/pinot/pull/7997#discussion_r794317969
##########
File path: kubernetes/helm/pinot/templates/controller/ingress.yaml
##########
@@ -0,0 +1,30 @@
+{{- if .Values.controller.ingress.enabled -}}
+{{- $ingressPath := .Values.controller.ingress.path -}}
+{{- $serviceName := include "pinot.controller.fullname" . -}}
+{{- $servicePort := .Values.controller.service.port -}}
+apiVersion: extensions/v1beta1
Review comment:
Sounds good.
I also checked that this `extensions/v1beta1` is deprecated on 1.22.
https://kubernetes.io/docs/reference/using-api/deprecation-guide/#ingress-v122
How about change this ingress file from `ingress.yaml` to
`ingress-v1beta1.yaml`, and make the flag to enable it to
`.Values.controller.ingress.v1beta1.enabled`? So we can add another
`ingress.yaml` file with `networking.k8s.io/v1` api.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
