xiangfu0 commented on a change in pull request #7997:
URL: https://github.com/apache/pinot/pull/7997#discussion_r794328610
##########
File path: kubernetes/helm/pinot/templates/controller/ingress.yaml
##########
@@ -0,0 +1,30 @@
+{{- if .Values.controller.ingress.enabled -}}
+{{- $ingressPath := .Values.controller.ingress.path -}}
+{{- $serviceName := include "pinot.controller.fullname" . -}}
+{{- $servicePort := .Values.controller.service.port -}}
+apiVersion: extensions/v1beta1
Review comment:
or we can just keep the file name still `ingress.yaml` and use flags
`.Values.controller.ingress.v1beta1.enabled`,
.Values.controller.ingress.v1.enabled` to switch between two APIs.
##########
File path: kubernetes/helm/pinot/templates/controller/ingress.yaml
##########
@@ -0,0 +1,30 @@
+{{- if .Values.controller.ingress.enabled -}}
+{{- $ingressPath := .Values.controller.ingress.path -}}
+{{- $serviceName := include "pinot.controller.fullname" . -}}
+{{- $servicePort := .Values.controller.service.port -}}
+apiVersion: extensions/v1beta1
Review comment:
Actually we can just keep the file name still `ingress.yaml` and use
flags `.Values.controller.ingress.v1beta1.enabled`,
.Values.controller.ingress.v1.enabled` to switch between two APIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
