richardstartin commented on a change in pull request #8083:
URL: https://github.com/apache/pinot/pull/8083#discussion_r794437614



##########
File path: 
pinot-core/src/main/java/org/apache/pinot/core/transport/ServerChannels.java
##########
@@ -139,22 +143,33 @@ private void attachSSLHandler(SocketChannel ch) {
       }
     }
 
-    synchronized void sendRequest(String rawTableName, AsyncQueryResponse 
asyncQueryResponse,
-        ServerRoutingInstance serverRoutingInstance, InstanceRequest 
instanceRequest)
+    private void sendRequestOrTimeOut(String rawTableName, AsyncQueryResponse 
asyncQueryResponse,
+        ServerRoutingInstance serverRoutingInstance, byte[] requestBytes, long 
timeoutMs)
+        throws Exception {
+      _channelLock.lock();
+      if (_channelLock.tryLock(timeoutMs, TimeUnit.MILLISECONDS)) {

Review comment:
       Line 149 looks unintentional




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to