mqliang commented on a change in pull request #8083:
URL: https://github.com/apache/pinot/pull/8083#discussion_r796146817
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/transport/ServerChannels.java
##########
@@ -139,22 +143,32 @@ private void attachSSLHandler(SocketChannel ch) {
}
}
- synchronized void sendRequest(String rawTableName, AsyncQueryResponse
asyncQueryResponse,
- ServerRoutingInstance serverRoutingInstance, InstanceRequest
instanceRequest)
+ private void sendRequestOrTimeOut(String rawTableName, AsyncQueryResponse
asyncQueryResponse,
Review comment:
done
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/transport/ServerChannels.java
##########
@@ -94,9 +97,10 @@ public void shutDown() {
@ThreadSafe
private class ServerChannel {
- final TSerializer _serializer = new TSerializer(new
TCompactProtocol.Factory());
final ServerRoutingInstance _serverRoutingInstance;
final Bootstrap _bootstrap;
+ // lock to protect channel as requests must be written into channel
sequentially
+ private final ReentrantLock _channelLock = new ReentrantLock();
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
