apucher commented on a change in pull request #8082:
URL: https://github.com/apache/pinot/pull/8082#discussion_r796092701
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/util/ListenerConfigUtil.java
##########
@@ -167,24 +172,38 @@ private ListenerConfigUtil() {
return listeners;
}
- private static ListenerConfig buildListenerConfig(PinotConfiguration config,
String namespace, String protocol,
+ private static ListenerConfig buildListenerConfig(PinotConfiguration config,
String namespace, String name,
Review comment:
the listener config originally required the listener name to be the
protocol. now, the protocol can be configured separately from the listener
name, i.e. it's possible to have two HTTPS listeners - one internally and the
other externally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
