daniellavoie commented on a change in pull request #8082:
URL: https://github.com/apache/pinot/pull/8082#discussion_r796093723
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/util/ListenerConfigUtil.java
##########
@@ -167,24 +172,38 @@ private ListenerConfigUtil() {
return listeners;
}
- private static ListenerConfig buildListenerConfig(PinotConfiguration config,
String namespace, String protocol,
+ private static ListenerConfig buildListenerConfig(PinotConfiguration config,
String namespace, String name,
Review comment:
The idea is that you can run multiple listeners for the same protocol.
For example, running 2 https listeners serving different certificates with
different keystore configurations. In that case, protocol is duplicate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
