richardstartin commented on a change in pull request #8211:
URL: https://github.com/apache/pinot/pull/8211#discussion_r808496495
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/json/MutableJsonIndex.java
##########
@@ -73,12 +73,16 @@ public MutableJsonIndex() {
*/
public void add(String jsonString)
throws IOException {
- List<Map<String, String>> flattenedRecords =
JsonUtils.flatten(JsonUtils.stringToJsonNode(jsonString));
- _writeLock.lock();
try {
- addFlattenedRecords(flattenedRecords);
+ List<Map<String, String>> flattenedRecords =
JsonUtils.flatten(JsonUtils.stringToJsonNode(jsonString));
+ _writeLock.lock();
+ try {
+ addFlattenedRecords(flattenedRecords);
+ } finally {
+ _writeLock.unlock();
+ }
} finally {
- _writeLock.unlock();
+ _nextDocId++;
Review comment:
ensures JSON index docId advances on error to avoid cross match
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
