richardstartin commented on a change in pull request #8211:
URL: https://github.com/apache/pinot/pull/8211#discussion_r808501700
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java
##########
@@ -541,9 +544,7 @@ private void updateDictionary(GenericRow row) {
}
}
- private void addNewRow(GenericRow row)
- throws IOException {
- int docId = _numDocsIndexed;
+ private void addNewRow(int docId, GenericRow row) {
Review comment:
All exceptions are caught except for ForwardIndex, which is assumed not
to fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
