Jackie-Jiang commented on a change in pull request #8228:
URL: https://github.com/apache/pinot/pull/8228#discussion_r812217992
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/query/SelectionOrderByOperator.java
##########
@@ -180,13 +207,51 @@ public String toExplainString() {
@Override
protected IntermediateResultsBlock getNextBlock() {
- if (_expressions.size() == _orderByExpressions.size()) {
+ if (_numOrderByColsPreSorted == _orderByExpressions.size()) {
Review comment:
(code format) indentation is not correct
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/query/SelectionOrderByOperator.java
##########
@@ -117,6 +119,31 @@ public String toExplainString() {
return stringBuilder.append(')').toString();
}
+ private void pruneOrderByColumns() {
Review comment:
We don't need to track `_numOrderByColsPreSorted` (the method name does
not reflect the functionality as well). Suggest changing this method to
`private boolean isAllOrderByColumnsSorted()` and call it in `getNextBlock()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
