Jackie-Jiang commented on a change in pull request #8228:
URL: https://github.com/apache/pinot/pull/8228#discussion_r813223044
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/plan/SelectionPlanNode.java
##########
@@ -59,12 +59,15 @@ public SelectionPlanNode(IndexSegment indexSegment,
QueryContext queryContext) {
Math.min(limit, DocIdSetPlanNode.MAX_DOC_PER_CALL)).run();
return new SelectionOnlyOperator(_indexSegment, _queryContext,
expressions, transformOperator);
} else {
- // Selection order-by
- if (orderByExpressions.size() == expressions.size()) {
+ if (isAllOrderByColumnsSorted(orderByExpressions)) { // no sorting
needed
+ TransformOperator transformOperator =
+ new TransformPlanNode(_indexSegment, _queryContext,
expressions, DocIdSetPlanNode.MAX_DOC_PER_CALL).run();
Review comment:
We can reduce the block size in `TransformOperator`
```suggestion
new TransformPlanNode(_indexSegment, _queryContext,
expressions, Math.min(limit + _queryContext.getOffset(),
DocIdSetPlanNode.MAX_DOC_PER_CALL))).run();
```
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/plan/SelectionPlanNode.java
##########
@@ -59,12 +59,15 @@ public SelectionPlanNode(IndexSegment indexSegment,
QueryContext queryContext) {
Math.min(limit, DocIdSetPlanNode.MAX_DOC_PER_CALL)).run();
return new SelectionOnlyOperator(_indexSegment, _queryContext,
expressions, transformOperator);
} else {
- // Selection order-by
- if (orderByExpressions.size() == expressions.size()) {
+ if (isAllOrderByColumnsSorted(orderByExpressions)) { // no sorting
needed
+ TransformOperator transformOperator =
+ new TransformPlanNode(_indexSegment, _queryContext,
expressions, DocIdSetPlanNode.MAX_DOC_PER_CALL).run();
+ return new SelectionOrderByOperator(_indexSegment, _queryContext,
expressions, transformOperator, true);
+ } else if (orderByExpressions.size() == expressions.size()) { //
Selection order-by
// All output expressions are ordered
TransformOperator transformOperator =
- new TransformPlanNode(_indexSegment, _queryContext, expressions,
DocIdSetPlanNode.MAX_DOC_PER_CALL).run();
- return new SelectionOrderByOperator(_indexSegment, _queryContext,
expressions, transformOperator);
+ new TransformPlanNode(_indexSegment, _queryContext,
expressions, DocIdSetPlanNode.MAX_DOC_PER_CALL).run();
Review comment:
Please reformat the changes with [Pinot
Style](https://docs.pinot.apache.org/developers/developers-and-contributors/code-setup#intellij)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
