klsince commented on pull request #8240: URL: https://github.com/apache/pinot/pull/8240#issuecomment-1049081411
hi @jackjlli @jtao15 thanks for the insights. I see currently conflict is checked with equality check like CollectionUtils.isEqualCollection. I wonder why it's not checking if there is overlap between segmentFrom sets instead? I'm thinking if I should check equality or overlap between segmentTo sets for the validation mentioned in your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
