klsince commented on a change in pull request #8240:
URL: https://github.com/apache/pinot/pull/8240#discussion_r814279669



##########
File path: 
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##########
@@ -2878,13 +2878,13 @@ public String startReplaceSegments(String 
tableNameWithType, List<String> segmen
           // By here, the lineage entry is either 'IN_PROGRESS' or 'COMPLETED'.
 
           // When 'forceCleanup' is enabled, we need to proactively clean up 
at the following cases:
-          // 1. Revert the lineage entry when we find the lineage entry with 
the same 'segmentFrom' values. This is
+          // 1. Revert the lineage entry when we find the lineage entry with 
overlapped 'segmentFrom' values. This is
           //    used to un-block the segment replacement protocol if the 
previous attempt failed in the middle.
           // 2. Proactively delete the oldest data snapshot to make sure that 
we only keep at most 2 data snapshots
           //    at any time in case of REFRESH use case.
           if (forceCleanup) {
-            if (lineageEntry.getState() == LineageEntryState.IN_PROGRESS && 
CollectionUtils
-                .isEqualCollection(segmentsFrom, 
lineageEntry.getSegmentsFrom())) {
+            if (lineageEntry.getState() == LineageEntryState.IN_PROGRESS && 
!Collections

Review comment:
       found I pushed this change accidentally. I'll revert/refine this part in 
coming PR: https://github.com/apache/pinot/pull/8242 
   
   but interestingly, looks like all tests were fine with this change, even 
disjoint is more strict than equality check.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to