yupeng9 commented on a change in pull request #8233:
URL: https://github.com/apache/pinot/pull/8233#discussion_r815380762
##########
File path:
pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/http/HttpClient.java
##########
@@ -0,0 +1,130 @@
+/**
Review comment:
Not really. I think this is an integral part to show how the connector
is used as in `QuickStart`, without it I don't think the connector is complete.
It doesn't make sense to expect developers to manually create the Schema as
well as TableConfig, not to mention several configurations decoration needed in
the `PinotConnectionUtils `.
Xiang's point is that in later PR we can refactor this part of code with a
reusable client lib. However, from the connector's user perspective, it doesn't
change the way of using the connector.
Makes sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
