walterddr commented on a change in pull request #8233:
URL: https://github.com/apache/pinot/pull/8233#discussion_r815384092
##########
File path:
pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/http/HttpClient.java
##########
@@ -0,0 +1,130 @@
+/**
Review comment:
hmm. I must have missed something. here is what I did:
1. deleted the entire folder under
`src/main/java/org/apache/pinot/connector/flink/http`.
2. run `mvn test -pl pinot-connectors/pinot-flink-connector`
everything runs pass. this proves that the http folder has nothing to do
with this PR. yes?
did you forget to add a Quickstart? I don't see a quickstart in this PR or
any changes outside of the pinot-flink-connector module. (and if so, let's add
it in a separate PR i suggest)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
