richardstartin commented on a change in pull request #8261:
URL: https://github.com/apache/pinot/pull/8261#discussion_r816223889



##########
File path: 
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/predicate/RegexpLikePredicateEvaluatorFactory.java
##########
@@ -64,6 +65,7 @@ public static BaseRawValueBasedPredicateEvaluator 
newRawValueBasedEvaluator(Rege
   private static final int PATTERN_FLAG = Pattern.UNICODE_CASE | 
Pattern.CASE_INSENSITIVE;
 
   private static final class DictionaryBasedRegexpLikePredicateEvaluator 
extends BaseDictionaryBasedPredicateEvaluator {
+    private final Matcher _matcher;

Review comment:
       OK, I will move the compilation to `RegexpLikePredicate` too, in order 
to deduplicate some code.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to