Jackie-Jiang commented on a change in pull request #8261:
URL: https://github.com/apache/pinot/pull/8261#discussion_r816258477
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/request/context/predicate/RegexpLikePredicate.java
##########
@@ -48,6 +50,13 @@ public String getValue() {
return _value;
}
+ public Pattern getPattern() {
+ if (_pattern == null) {
Review comment:
The pattern can be accessed by multiple threads, so might be better to
make it `volatile` or make it atomic swap?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
