jtao15 commented on pull request #8345: URL: https://github.com/apache/pinot/pull/8345#issuecomment-1067227093
> I think for `NUMBER_OF_REPLICAS`, `PERCENT_OF_REPLICAS`, `SEGMENTS_IN_ERROR_STATE` and `PERCENT_SEGMENTS_AVAILABLE` we should by default exclude the replaced segments. Adding 2 sets of metrics can cause confusion and unnecessary overhead. For `SEGMENT_COUNT`, I'd suggest also excluding the replaced segments by default, but add one `SEGMENT_COUNT_INCLUDING_REPLACED` for debugging and tracking purpose. Make sense, will update the pr soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
