jackjlli commented on a change in pull request #8345:
URL: https://github.com/apache/pinot/pull/8345#discussion_r827444668
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/SegmentStatusChecker.java
##########
@@ -161,6 +172,9 @@ private void updateSegmentMetrics(String tableNameWithType,
Context context) {
int nOffline = 0; // Keeps track of number segments with no online replicas
int nSegments = 0; // Counts number of segments
for (String partitionName : idealState.getPartitionSet()) {
+ if (!segmentsExcludeReplaced.contains(partitionName)) {
Review comment:
Just curious why not use `segmentsExcludeReplaced` directly in the for
loop?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
