dongxiaoman commented on a change in pull request #8335:
URL: https://github.com/apache/pinot/pull/8335#discussion_r826378911
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java
##########
@@ -1336,12 +1314,7 @@ public LLRealtimeSegmentDataManager(SegmentZKMetadata
segmentZKMetadata, TableCo
_messageDecoder =
StreamDecoderProvider.create(_partitionLevelStreamConfig, fieldsToRead);
_clientId = streamTopic + "-" + _partitionGroupId;
- // Create record transformer
- _recordTransformer =
CompositeTransformer.getDefaultTransformer(tableConfig, schema);
-
- // Create complex type transformer
- _complexTypeTransformer =
ComplexTypeTransformer.getComplexTypeTransformer(tableConfig);
-
+ _transformPipeline = new TransformPipeline(tableConfig, schema);
Review comment:
On second thought, @npawar since that File touches even more places in
Pinot, can we keep the PR small? I promise I will do a follow up PR to further
tweak the `TransformPipeline` so it will be used by
`SegmentIndexCreationDriverImpl` too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
