dongxiaoman commented on pull request #8335: URL: https://github.com/apache/pinot/pull/8335#issuecomment-1067426233
> @mcvsubbu I totally agree on that part, and for that large feature, we will follow the protocol. I mentioned our POC mostly for transparency. This specific PR is a pure refactor, not tied to any feature. It has at least 3 benefits: 1. Compact 3 member variables in Realtime DataManager into one, reduced dependency in `import` too. 2. Shortens Realtime DataManager code length, makes the logic like a module 3. The `SegmentIndexCreationDriverImpl` has nearly identical logic too, we will make sure all the transform and validation are done in one class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
