dongxiaoman commented on a change in pull request #8335: URL: https://github.com/apache/pinot/pull/8335#discussion_r827371971
########## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/TransformPipeline.java ########## @@ -0,0 +1,116 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.data.manager.realtime; + +import java.util.ArrayList; +import java.util.Collection; +import java.util.List; +import javax.annotation.Nonnull; +import org.apache.pinot.segment.local.recordtransformer.ComplexTypeTransformer; +import org.apache.pinot.segment.local.recordtransformer.CompositeTransformer; +import org.apache.pinot.segment.local.recordtransformer.RecordTransformer; +import org.apache.pinot.segment.local.utils.IngestionUtils; +import org.apache.pinot.spi.config.table.TableConfig; +import org.apache.pinot.spi.data.Schema; +import org.apache.pinot.spi.data.readers.GenericRow; + + +/** + * The class for transforming validating GenericRow data against table schema and table config. + * It is used mainly but not limited by RealTimeDataManager for each row that is going to be indexed into Pinot. + */ +public class TransformPipeline { + private final RecordTransformer _recordTransformer; + private final ComplexTypeTransformer _complexTypeTransformer; + + /** + * Constructing a transform pipeline based on TableConfig and table schema. + * @param tableConfig the config for the table + * @param schema the table schema + */ + public TransformPipeline(TableConfig tableConfig, Schema schema) { + // Create record transformer + _recordTransformer = CompositeTransformer.getDefaultTransformer(tableConfig, schema); + + // Create complex type transformer + _complexTypeTransformer = ComplexTypeTransformer.getComplexTypeTransformer(tableConfig); + } + + /** + * Process and validate the decoded row against schema. + * @param decodedRow the row data to pass in + * @param reusedResult the reused result so we can reduce objects created for each row + * @throws Exception when data has issues like schema validation. Fetch the partialResult from Exception + */ + public void processRow(GenericRow decodedRow, @Nonnull Result reusedResult) + throws Exception { + reusedResult.reset(); + if (_complexTypeTransformer != null) { + // TODO: consolidate complex type transformer into composite type transformer + decodedRow = _complexTypeTransformer.transform(decodedRow); + } + Collection<GenericRow> rows = (Collection<GenericRow>) decodedRow.getValue(GenericRow.MULTIPLE_RECORDS_KEY); + if (rows != null) { + for (GenericRow row : rows) { + GenericRow transformedRow = _recordTransformer.transform(row); + if (transformedRow != null && IngestionUtils.shouldIngestRow(transformedRow)) { + reusedResult.addTransformedRows(transformedRow); + } else { + reusedResult.incSkippedRowCount(); + } + } + } else { + GenericRow transformedRow = _recordTransformer.transform(decodedRow); + if (transformedRow != null && IngestionUtils.shouldIngestRow(transformedRow)) { + reusedResult.addTransformedRows(transformedRow); + } else { + reusedResult.incSkippedRowCount(); + } Review comment: Changed to one function now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
