klsince commented on a change in pull request #8242:
URL: https://github.com/apache/pinot/pull/8242#discussion_r830221603
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##########
@@ -2963,6 +2961,25 @@ public String startReplaceSegments(String
tableNameWithType, List<String> segmen
return segmentLineageEntryId;
}
+ // TODO: Add more conflict checks over segmentsTo later. For example, for
APPEND table,
+ // if the new segments from 2 batch jobs are overlapping, we reject
one of job.
+ private static boolean isConflicted(List<String> segmentsFrom, LineageEntry
lineageEntry, TableConfig tableConfig) {
+ if (!segmentsFrom.isEmpty()) {
+ // It's conflicted if there is any overlap between segmentsFrom.
+ return !Collections.disjoint(segmentsFrom,
lineageEntry.getSegmentsFrom());
+ }
+ // For REFRESH table, it's conflicted if both segmentsFrom are empty.
+ if (isRefreshTable(tableConfig)) {
Review comment:
sry folks, I was distracted from this PR. IIUC, we'd like to avoid the
specific handling on refresh table and simply do the disjoint check on
segmentsFrom for now. So I just left the UT cases in this PR. I'll probably
close the PR if we still need more discussions to converge on this. but lemme
know your thoughts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
