richardstartin commented on a change in pull request #8343:
URL: https://github.com/apache/pinot/pull/8343#discussion_r835893831
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java
##########
@@ -170,17 +188,14 @@ public void init(SegmentGeneratorConfig
segmentCreationSpec, SegmentIndexCreatio
Preconditions.checkState(dictEnabledColumn ||
!invertedIndexColumns.contains(columnName),
"Cannot create inverted index for raw index column: %s", columnName);
- IndexCreationContext.Common context = IndexCreationContext.builder()
- .withIndexDir(_indexDir)
- .withCardinality(columnIndexCreationInfo.getDistinctValueCount())
- .withDictionary(dictEnabledColumn)
- .withFieldSpec(fieldSpec)
- .withTotalDocs(segmentIndexCreationInfo.getTotalDocs())
+ IndexCreationContext.Common context =
IndexCreationContext.builder().withIndexDir(_indexDir)
Review comment:
I’ve seen this change applied on several branches, because the original
code is not formatted the way the automated formatting formats it. Which is
more readable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
