richardstartin commented on a change in pull request #8343:
URL: https://github.com/apache/pinot/pull/8343#discussion_r835895087
##########
File path:
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/creator/IndexCreationContext.java
##########
@@ -463,4 +492,17 @@ public boolean isFst() {
return _sortedUniqueElementsArray;
}
}
+
+ class Timestamp extends Wrapper {
Review comment:
A timestamp index isn’t really an index, it’s a collection of
transformed columns with a range index, so there’s nothing to override, and the
implementation is dispersed throughout the codebase anyway so couldn’t be
overridden at a single cut point like IndexCreationContexy is designed for, so
we don’t need Timestamp here and couldn’t use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
