snleee commented on code in PR #8732:
URL: https://github.com/apache/pinot/pull/8732#discussion_r876332531
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/function/GroovyFunctionEvaluator.java:
##########
@@ -86,10 +86,6 @@ public List<String> getArguments() {
public Object evaluate(GenericRow genericRow) {
for (String argument : _arguments) {
Object value = genericRow.getValue(argument);
- if (value == null) {
Review Comment:
+1. We need to double check on what `_script.run()` would return for
NullPointerException in the groovy side and we should handle it properly (e.g.
on exception, we put `null` value. Or, we can even throw the exception and fail
the segment creation.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
