PrachiKhobragade commented on code in PR #8732:
URL: https://github.com/apache/pinot/pull/8732#discussion_r876337073
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/function/GroovyFunctionEvaluator.java:
##########
@@ -86,10 +86,6 @@ public List<String> getArguments() {
public Object evaluate(GenericRow genericRow) {
for (String argument : _arguments) {
Object value = genericRow.getValue(argument);
- if (value == null) {
Review Comment:
after the groovy transform is run, the null value transform will be run, and
if any value still remains null, NullValueTransformer will set the default
value based on datatype. We run all these transformations in sequence.
```
return new CompositeTransformer(Arrays
.asList(new ExpressionTransformer(tableConfig, schema), new
FilterTransformer(tableConfig),
new DataTypeTransformer(schema), new
NullValueTransformer(tableConfig, schema),
new SanitizationTransformer(schema)));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
