Jackie-Jiang commented on code in PR #8729:
URL: https://github.com/apache/pinot/pull/8729#discussion_r876449656
##########
pinot-broker/src/main/java/org/apache/pinot/broker/broker/BrokerAdminApiApplication.java:
##########
@@ -89,7 +91,11 @@ private void setupSwagger() {
beanConfig.setDescription("APIs for accessing Pinot broker information");
beanConfig.setContact("https://github.com/apache/pinot";);
beanConfig.setVersion("1.0");
- beanConfig.setSchemes(new String[]{CommonConstants.HTTP_PROTOCOL,
CommonConstants.HTTPS_PROTOCOL});
+ if
(CommonConstants.HTTPS_PROTOCOL.equalsIgnoreCase(_swaggerDefaultProtocol)) {
+ beanConfig.setSchemes(new String[]{CommonConstants.HTTPS_PROTOCOL,
CommonConstants.HTTP_PROTOCOL});
Review Comment:
Should we still set HTTP?
##########
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java:
##########
@@ -63,6 +63,7 @@ public class ControllerConf extends PinotConfiguration {
public static final String HELIX_CLUSTER_NAME =
"controller.helix.cluster.name";
public static final String CLUSTER_TENANT_ISOLATION_ENABLE =
"cluster.tenant.isolation.enable";
public static final String CONSOLE_WEBAPP_ROOT_PATH =
"controller.query.console";
+ public static final String CONSOLE_WEBAPP_DEFAULT_PROTOCOL =
"controller.query.console.default.protocol";
Review Comment:
Why is controller key different from others? I don't think it applies to the
query console
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
