klsince commented on code in PR #8729:
URL: https://github.com/apache/pinot/pull/8729#discussion_r877285410
##########
pinot-broker/src/main/java/org/apache/pinot/broker/broker/BrokerAdminApiApplication.java:
##########
@@ -89,7 +91,11 @@ private void setupSwagger() {
beanConfig.setDescription("APIs for accessing Pinot broker information");
beanConfig.setContact("https://github.com/apache/pinot";);
beanConfig.setVersion("1.0");
- beanConfig.setSchemes(new String[]{CommonConstants.HTTP_PROTOCOL,
CommonConstants.HTTPS_PROTOCOL});
+ if
(CommonConstants.HTTPS_PROTOCOL.equalsIgnoreCase(_swaggerDefaultProtocol)) {
+ beanConfig.setSchemes(new String[]{CommonConstants.HTTPS_PROTOCOL,
CommonConstants.HTTP_PROTOCOL});
Review Comment:
yeah, still needed at least for those quickstart examples, and perhaps for
users not enabling TLS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
