Jackie-Jiang commented on code in PR #8737:
URL: https://github.com/apache/pinot/pull/8737#discussion_r877513690
##########
pinot-core/src/main/java/org/apache/pinot/core/startree/StarTreeUtils.java:
##########
@@ -48,14 +48,11 @@ public class StarTreeUtils {
private StarTreeUtils() {
}
- public static final String USE_STAR_TREE_KEY = "useStarTree";
-
/**
* Returns whether star-tree is disabled for the query.
*/
public static boolean isStarTreeDisabled(QueryContext queryContext) {
- Map<String, String> debugOptions = queryContext.getDebugOptions();
- return debugOptions != null &&
"false".equalsIgnoreCase(debugOptions.get(USE_STAR_TREE_KEY));
+ return queryContext.isSkipStartree();
Review Comment:
This is backward-incompatible change. Suggest still supporting the old way
of skipping star-tree so that user can put both options during the migration,
then we may deprecate it in the future.
We can apply this logic in `InstancePlanMakerImplV2.applyQueryOptions()`. If
either of the flag is set, we should skip the star-tree
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -248,6 +248,7 @@ public static class Request {
public static class QueryOptionKey {
public static final String TIMEOUT_MS = "timeoutMs";
public static final String SKIP_UPSERT = "skipUpsert";
+ public static final String SKIP_STARTREE = "skipStartree";
Review Comment:
We usually treat star tree as 2 words, same for other places
```suggestion
public static final String SKIP_STAR_TREE = "skipStarTree";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
