Jackie-Jiang commented on code in PR #8737:
URL: https://github.com/apache/pinot/pull/8737#discussion_r879884812
##########
pinot-core/src/main/java/org/apache/pinot/core/plan/maker/InstancePlanMakerImplV2.java:
##########
@@ -186,10 +186,14 @@ public Plan makeInstancePlan(List<IndexSegment>
indexSegments, QueryContext quer
private void applyQueryOptions(QueryContext queryContext) {
Map<String, String> queryOptions = queryContext.getQueryOptions();
+ Map<String, String> debugOptions = queryContext.getDebugOptions();
// Set skipUpsert
queryContext.setSkipUpsert(QueryOptionsUtils.isSkipUpsert(queryOptions));
+ // Set skipStartree
Review Comment:
(nit)
```suggestion
// Set skipStarTree
```
##########
pinot-core/src/main/java/org/apache/pinot/core/startree/StarTreeUtils.java:
##########
@@ -48,14 +48,11 @@ public class StarTreeUtils {
private StarTreeUtils() {
}
- public static final String USE_STAR_TREE_KEY = "useStarTree";
-
/**
* Returns whether star-tree is disabled for the query.
*/
public static boolean isStarTreeDisabled(QueryContext queryContext) {
Review Comment:
(minor) This helper method does not add much value IMO. We may remove this
method and directly call `queryContext.isSkipStarTree()`
##########
pinot-core/src/main/java/org/apache/pinot/core/query/request/context/QueryContext.java:
##########
@@ -101,6 +101,8 @@ public class QueryContext {
private boolean _enablePrefetch;
// Whether to skip upsert for the query
private boolean _skipUpsert;
+ // Whether to skip upsert for the query
Review Comment:
```suggestion
// Whether to skip star-tree index for the query
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
