walterddr opened a new pull request, #8757:
URL: https://github.com/apache/pinot/pull/8757
Split ClusterTest and BaseClusterIntegrationTest
the former should deal with starting a cluster, the latter should deal with
loading/maintaining a dataset.
Details
===
- renamed `BaseClusterIntegrationTest` to `ClusterIntegrationTestDataSet`
and no longer extend from `ClusterTest`. instead `ClusterTest` is passed in as
constructor parameter.
- also renamed the `BaseClusterIntegrationTestSet` to
`ClusterIntegrationTestDataAndQuerySet` as the only extended functionality is
the SQL list and a bit more utility functions.
- created a default implementation using the Airline dataset.
- move more of the cluster-related settings to `ClusterTest`
- for each integration test, it either (1) extend from `ClusterTest` or (2)
use a `ClusterTest` base class as a singleton object that shared the cluster;
- in the case of a shared singleton `ClusterTest` object, each test case
instantiate its own `ClusterIntegrationTestDataSet` and pass the singleton
`ClusterTest` object as the underlying data.
- also the table/schema name is overwritten so that the table will not
conflict with each other test cases.
- fix compilation issue on actual test cases.
TODO
===
- as a follow up we should bundle different data set loading together within
the same `@BeforeGroups` and use a singleton instance to load the data for
testing. this can be done by providing the default `TestDataSet` for each
singleton object shared cluster between test cases.
- depends on #8744.
- related to #8745
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
